[QFJ-143] DataDictionary doesn't preserve the "required" attribute of header/trailer fields Created: 24/Feb/07  Updated: 12/Apr/07  Resolved: 24/Feb/07

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.0.5
Fix Version/s: 1.1.0

Type: Bug Priority: Default
Reporter: Toli Kuznets Assignee: Toli Kuznets
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
is related to QFJ-145 Provide a Session.validateMessageBody... Closed

 Description   

DataDictionary.load() method currently hardcodes all the header/trailer fields to be "not required".
As a result, even validating a message without a BeginString or SenderCompID passes, even though those fields are obviously required in the FIX dictionary file.

Source example:
String required = "false";
addHeaderField(lookupXMLFieldNumber(document, name), required.equals("true"));

Need to behave the same as with regular fields.



 Comments   
Comment by Toli Kuznets [ 24/Feb/07 ]

i'll do the copy/paste from the regular message parsing code first and check the fix in.

i'll decomp the code to reuse all the common cases later in a separate check-in.

Comment by Toli Kuznets [ 24/Feb/07 ]

Fixed in checkin 593.

Generated at Sat Nov 23 10:27:08 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.