[QFJ-236] Make the time interval when Test Request being sent configurable Created: 12/Sep/07 Updated: 11/Feb/09 Resolved: 19/Sep/07 |
|
Status: | Closed |
Project: | QuickFIX/J |
Component/s: | Engine |
Affects Version/s: | 1.2.1 |
Fix Version/s: | 1.3.0 |
Type: | New Feature | Priority: | Default |
Reporter: | Toli Kuznets | Assignee: | Toli Kuznets |
Resolution: | Fixed | Votes: | 0 |
Labels: | None |
Attachments: | qfj-236.patch qfj-236.patch |
Description |
We've been going through a certification process with TransactTools (http://www.openfix.net/), and encountered a different expected behaviour with sending Test Requests. In the TransactTools test, they skip a heartbeat message and expect our quickfix engine (Ie QFJ) to send a test request: Seems like they expect it to be sent within HeartBeatInt+9secs. Looking at the code in SessionState.isTestRequestNeeded(), it calculates the Test Request delay as 1.5 * (HeartBeatInt + numTestRequestsSent + 1), which translates into HeartBeatInt * 1.5 (for first request) = 30 + 15secs, which is over the +9 seconds that's expected. Is there a known spec for this formula or was it something "reasonable" but not necessarily standard? Maybe it's something we need to make configurable to satisfy different expectations form counterparties? |
Comments |
Comment by Toli Kuznets [ 19/Sep/07 ] |
Moved this from a question to an RFE will make the time interval configurable. |
Comment by Toli Kuznets [ 19/Sep/07 ] |
Patch for this bug. added unit tests to verify that the parameter is passed in correctly, and that it's being used correctly as well. |
Comment by Toli Kuznets [ 19/Sep/07 ] |
oh, and i forgot to add changes to documentation - will definitely do that before i submit it. |
Comment by Toli Kuznets [ 19/Sep/07 ] |
updated patch with documentation change |
Comment by Toli Kuznets [ 19/Sep/07 ] |
fix checked in rev 740 |