[QFJ-274] Accessibility of methods in FieldMap for getting Groups from default to public Created: 19/Dec/07  Updated: 15/Jan/08  Resolved: 10/Jan/08

Status: Closed
Project: QuickFIX/J
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3.1

Type: Improvement Priority: Default
Reporter: Hemant Bhatia Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Environment:

Unix / Windows


 Description   

Can the accessiblity of the follwing methods in FieldMap class be changed from Default to Public ?

/* package */
List<Group> getGroups(int field) {
List<Group> groupList = groups.get(field);
if (groupList == null)

{ groupList = new ArrayList<Group>(); groups.put(field, groupList); }

return groupList;
}

int getGroupCount(int tag)

{ return getGroups(tag).size(); }

Map<Integer,List<Group>> getGroups()

{ return groups; }

It will be really helpful in order to iterate through the groups in the message generically.

 Comments   
Comment by Steve Bate [ 22/Dec/07 ]

I'll make the getGroupCount() method public. I'm not going to expose the other two methods because they are not type safe and I'd have to copy all the groups to be sure they weren't modified outside the FieldMap.

Generated at Sat Nov 23 14:15:11 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.