[QFJ-283] quickfix fail to send reject when the message parsing fails due to invalid data Created: 28/Dec/07  Updated: 15/Nov/12  Resolved: 12/Jan/08

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.2.0, 1.2.1, 1.3.0
Fix Version/s: None

Type: Bug Priority: Major
Reporter: sarath Assignee: Unassigned
Resolution: Cannot Reproduce Votes: 0
Labels: None


 Description   

This issue arise when the group data is set incorrectly by users. Sometimes users leave the group tags empty(mainly the group count) with no value.

Below is the case where the test fail with NullPointerException. The exception is not caught in AbstractIOHandler.java and is never sent to client app causing the error to be ignored.

We should catch the exception and send reject to clients.

  1. @testcase 14i
  2. @Receive a message with repeating groups in which the "count" field value for a repeating group is incorrect.

iCONNECT

  1. logon message and response
    I8=FIX.4.235=A34=149=TW52=<TIME>56=ISLD98=0108=2
    E8=FIX.4.29=6035=A34=149=ISLD52=00000000-00:00:00.00056=TW98=0108=210=0

#------------------------

  1. begin message exchange
    #------------------------

#New order message with incorrect repeating group "count". NoTradingSessions (386)
I8=FIX.4.235=D34=249=TW52=<TIME>56=ISLD11=ID21=140=154=138=200.0055=INTC386=336=PRE-OPEN336=AFTER-HOURS60=<TIME>

  1. expect a reject
    E8=FIX.4.29=11835=334=249=ISLD52=00000000-00:00:00.00056=TW45=258=Incorrect NumInGroup count for repeating group371=386372=D10=0

 Comments   
Comment by Steve Bate [ 08/Jan/08 ]

Can you attach the test case so that the field delimeters are not lost? Thanks.

I'm curious what's causing the NullPointerException, but this is not exactly a case of an incorrect NumInGroup value. A missing group count tag might appear similar, but it has significantly different implications. Without a group count tag, the repeating groups effectively do not exist from a parsing perspective.

Comment by Steve Bate [ 12/Jan/08 ]

When I modify test 14i to remove the group count field, I receive a reject saying "Tag not defined for this message type:336". This is what I would expect since tag 336 would appear to be included in the main message body (which would be invalid). I saw no NullPointerException. Was this possibly coming from your application code?

Generated at Sat Nov 23 10:51:55 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.