[QFJ-304] EST Timezone SessionScheduleTest.testSettingsWithoutStartEndDayWithTimeZoneInTime() Created: 18/Mar/08 Updated: 07/Aug/08 Resolved: 26/Mar/08 |
|
Status: | Closed |
Project: | QuickFIX/J |
Component/s: | Build |
Affects Version/s: | 1.3.1 |
Fix Version/s: | 1.3.2 |
Type: | Bug | Priority: | Default |
Reporter: | Dustin Vain | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Environment: |
OS X 10.5.2 |
Description |
SessionScheduleTest.testSettingsWithoutStartEndDayWithTimeZoneInTime() uses the timezone "EST" when it sets the Session.SETTING_START_TIME and when it sets the tz for the "current time" in the tests. It uses "US/Central" for the Session.SETTING_END_TIME. The tests that follow assume that "US/Central" is 1 hour behind "EST". This is not always true. "US/Central" accounts for Daylight Savings and "EST" does not. So, during DST, the difference between these zones is 0 hours. This causes the following test to fail (line 398 in version 1.3.1), because it relies on the 1 hour timezone difference: I suggest using "US/Eastern" instead of "EST" in this test so that the test passes year round. |
Comments |
Comment by Steve Bate [ 25/Mar/08 ] |
Good point. Thanks! I'm make the change for the next release. |