[QFJ-306] JdbcStore has an incorrect query for the UPDATE, when it wants to update a message whose sequence was already entered... Created: 11/Apr/08  Updated: 07/Aug/08  Resolved: 17/Jun/08

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.3.1
Fix Version/s: 1.3.2

Type: Bug Priority: Default
Reporter: Tom Mowad Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Environment:

Everywhere



 Description   

The problem is in the function with prototype

public boolean set(int sequence, String message)

The mistaken code says:

update.setInt(offset++, sequence);
update.setString(offset, message);

But ought to be:

update.setString(offset++, message);
update.setInt(offset, sequence);

instead.

If we see the place where INSERT_UPDATE_MESSAGE is defined

INSERT_UPDATE_MESSAGE = "UPDATE " + messageTableName + " SET message=? " + "WHERE "
+ idWhereClause + " and msgseqnum=?";

it is clear that the message ought to be stored before the sequence number.



 Comments   
Comment by Dan Mihai Dumitriu [ 03/Jun/08 ]

This is a major bug. How come nobody has looked at it??

Generated at Wed Nov 27 01:00:27 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.