diff4.txt
diff4.txt
[QFJ-520] Documentation for ValidateFieldsOutOfOrder is incorrect Created: 10/May/10 Updated: 20/Mar/11 Resolved: 20/Mar/11 |
|
| Status: | Closed |
| Project: | QuickFIX/J |
| Component/s: | Documentation |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | None |
| Type: | Other | Priority: | Default |
| Reporter: | Rhys Yarranton | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
diff4.txt
diff4.txt
|
| Description |
|
The documentation for ValidateFieldsOutOfOrder reads: Search of the source code reveals that it has to do with mis-ordered repeating group fields. It does nothing about header fields in the body or vice versa. (Verified by experiment.) |
| Comments |
| Comment by Rhys Yarranton [ 12/May/10 ] |
|
On further investigation, it seems in an earlier version we were able tolerate header tags in the body. See also Also found that the behaviour around duplicate fields has changed, probably at about the same time. There is currently no way to relax it. (Believe it or not, we have seen problem gateways in production that produce dups.) The attached patch makes ValidateFieldsOutOfOrder allow header tags in the body. There may still be some holes out there. For example, suppose you turn off validation of user defined fields, and someone throws a repeating group at you that isn't in your data dictionary. I suspect this will show as a duplicate field. (Unless you use the new setting.) |
| Comment by Rhys Yarranton [ 25/Oct/10 ] |
|
Revised version of diff4.txt. First one was missing DefaultSessionFactory.java. |