[QFJ-533] NumberFormatException parsing message closes the session Created: 24/Jun/10 Updated: 23/Nov/17 Resolved: 23/Nov/17 |
|
Status: | Resolved |
Project: | QuickFIX/J |
Component/s: | None |
Affects Version/s: | 1.5.0 |
Fix Version/s: | 2.0.1 |
Type: | Bug | Priority: | Default |
Reporter: | Colin Crist | Assignee: | Christoph John |
Resolution: | Fixed | Votes: | 0 |
Labels: | None |
Description |
The following exception unwinds the stack completely - the MINA handler does not check for this exception: I think the handler should create a reject message and pass it back ? Tested with the latest code (23/7/2010) from trunk. INFO: FIX.4.4:MDFXSSUS_TUTOGB21->MDFX_SBOSUS3F: For input string: "abc" java.lang.NumberFormatException: For input string: "abc" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) at java.lang.Integer.parseInt(Integer.java:447) at java.lang.Integer.parseInt(Integer.java:497) at quickfix.Message.parseGroup(Message.java:575) at quickfix.Message.parseBody(Message.java:554) at quickfix.Message.parse(Message.java:467) at quickfix.MessageUtils.parse(MessageUtils.java:151) at quickfix.mina.AbstractIoHandler.messageReceived(AbstractIoHandler.java:116) at org.apache.mina.common.support.AbstractIoFilterChain$TailFilter.messageReceived(AbstractIoFilterChain.java:703) at org.apache.mina.common.support.AbstractIoFilterChain.callNextMessageReceived(AbstractIoFilterChain.java:362) at org.apache.mina.common.support.AbstractIoFilterChain.access$1100(AbstractIoFilterChain.java:54) at org.apache.mina.common.support.AbstractIoFilterChain$EntryImpl$1.messageReceived(AbstractIoFilterChain.java:800) at org.apache.mina.filter.codec.support.SimpleProtocolDecoderOutput.flush(SimpleProtocolDecoderOutput.java:62) at org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(ProtocolCodecFilter.java:200) at org.apache.mina.common.support.AbstractIoFilterChain.callNextMessageReceived(AbstractIoFilterChain.java:362) at org.apache.mina.common.support.AbstractIoFilterChain.access$1100(AbstractIoFilterChain.java:54) at org.apache.mina.common.support.AbstractIoFilterChain$EntryImpl$1.messageReceived(AbstractIoFilterChain.java:800) at org.apache.mina.common.support.AbstractIoFilterChain$HeadFilter.messageReceived(AbstractIoFilterChain.java:617) at org.apache.mina.common.support.AbstractIoFilterChain.callNextMessageReceived(AbstractIoFilterChain.java:362) at org.apache.mina.common.support.AbstractIoFilterChain.fireMessageReceived(AbstractIoFilterChain.java:353) at org.apache.mina.transport.socket.nio.SocketIoProcessor.read(SocketIoProcessor.java:246) at org.apache.mina.transport.socket.nio.SocketIoProcessor.process(SocketIoProcessor.java:206) at org.apache.mina.transport.socket.nio.SocketIoProcessor.access$500(SocketIoProcessor.java:44) at org.apache.mina.transport.socket.nio.SocketIoProcessor$Worker.run(SocketIoProcessor.java:506) at org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:43) at java.lang.Thread.run(Thread.java:595) |
Comments |
Comment by Christoph John [ 23/Nov/17 ] |
Fixed by https://github.com/pbyrne413 via https://github.com/quickfix-j/quickfixj/pull/150. |