[QFJ-534] Resend Request Synchronization Patch Created: 28/Jun/10  Updated: 12/Apr/11  Resolved: 12/Apr/11

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.4.0
Fix Version/s: 1.5.0

Type: Bug Priority: Critical
Reporter: SSE Assignee: Unassigned
Resolution: Duplicate Votes: 1
Labels: None
Environment:

All

Issue Links:
Duplicate
duplicates QFJ-429 Concurrency reading / writting file s... Closed

 Description   

QuickFIX/J has an issue with the file store and message sequence numbers when simultaneously answering a ResendRequest on a connection, and processing brand new messages routed to that connection which are also to be sent to the client. The file pointers were not handled correctly for reading stored messages which are to be sent as PossDups, and for new messages to be written to the outgoing file. This caused outgoing message store file corruption, and repeated / out of sequence seqnums being sent.

Fixed: synchronization QFJ patch, where the thread is blocked from sending new messages (i.e. buffering) until a ResendRequest is fully answered.

private void nextResendRequest(Message resendRequest) throws IOException, RejectLogon,
FieldNotFound, IncorrectDataFormat, IncorrectTagValue, UnsupportedMessageType,
InvalidMessage {
if (!verify(resendRequest, false, false))

{ return; }

// ******* ADDED *******
state.lockSenderMsgSeqNum();
try

{ int beginSeqNo = resendRequest.getInt(BeginSeqNo.FIELD); int endSeqNo = resendRequest.getInt(EndSeqNo.FIELD); getLog().onEvent( "Received ResendRequest FROM: " + beginSeqNo + " TO: " + formatEndSeqNum(endSeqNo)); .... // ******* ADDED ******* }

finally

{ state.unlockSenderMsgSeqNum(); }

}

(Internal reference: IC_57785)

 Comments   
Comment by Eric Deshayes [ 12/Apr/11 ]

This issue has already been fixed in 1.5.0.

Comment by Eric Deshayes [ 12/Apr/11 ]

Duplicate of QFJ-429

Generated at Sat Nov 23 11:34:16 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.