[QFJ-543] "connector" parameter in interface AcceptorSessionProvider.getSession() is undocumented and unclear Created: 19/Jul/10  Updated: 19/Jul/10

Status: Open
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.5.0
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Grant Birchmeier Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None


 Description   

See paste below from AcceptorSessionProvider. The parameter connector is absent from the javadoc, and it's not clear what it's for. As it's an interface, the parameter's purpose should be documented.

From the two instantiations of this interface (DynamicAcceptorSessionProvider and AbstractSocketAcceptor::StaticAcceptorSessionProvider), it appears this parameter is only used for dynamic sessions and is otherwise ignored.

/**

  • Return a session for this sessionID. The session might be
  • created dynamically.
  • @param sessionID
  • @return the associated session or null if no session can be
  • associated with the given ID.
    */
    Session getSession(SessionID sessionID, SessionConnector connector);


 Comments   
Comment by Grant Birchmeier [ 19/Jul/10 ]

Paste above is from r959 (the latest at time of bug creation).

Generated at Sat Nov 23 00:44:12 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.