Hi Nait,

what kind of performance improvements you are planning. I have also some thoughts collected over the last years.

Cheers, Jörg

Remove Matcher in double converter and verify only if the first charater is not '+', other cases will be handled by parseDouble; and ditto for int converter.

Hi Jorg,
this is mainly very focused parsing improvements that we've done after some profiling and that we are integrating to the trunk (as part of the integration of our changes).

I let you open another JIRA for other or deeper improvements.
We could have some talks about it to share your thoughts with ours.

Regards,
Abla

As we discussed on the developer list, the current converter implementation is not FIX-compliant. The purpose for the Regex match to validate the input before passing it to Double for parsing. If this is causing significant performance issues then we may want to implement a fast double parsing function that validates while is parses/converts the string to a double. We should also add a unit test that shows the conversion fails for formats like "1e6" (scientific notation) which is not allowed by FIX.

As discussed previously, changes have been reverted.
Committed in integration branch in Rev#1025.

As discussed, some improvement on the converters could be done but they should not change the FIX compliance.

Changes have been reverted and performance improvements will be handled later.