This needn't be "Major" priority on my account - we don't have any current need to do this. I just thought it would be nifty

Wiki page: http://www.quickfixj.org/confluence/x/EgI

I've added support for customizing MINA filters in the trunk. Just add a filter builder to your acceptor or initiator when you create them. If you need access to settings, pass the SessionSettings into the filter builder when you create it. Comments are welcome.

Hi Steve,

Looks good - certainly much cleaner without the extra factory some crazy guy suggested Could you maybe make setIoFilterChainBuilder part of the Connector interface? I don't think you should have to cast to SocketConnector (or subclass) to add it.

Cheers,
Brad.

Hi Brad,

I'm not sure that I want to put that method in the Connector interface because the interface is not socket-specific. For example, we might (probably will) have non-MINA connector implementation in the future. If you are setting the filter chain builder in your application set up, don't you already have a socket connector instance without needing the downcast?

Thanks for your suggestions and example code. I think this will be a good feature. When I have time I'll investigate how to provide SSL automatically in the MINA connector implementations.

Steve

Fair enough - I can see it makes sense if you're not wanting to bind the public quickfix API to MINA. I'm just playing around with the order executor at the moment, which declares it as Acceptor so needs the cast.

I'm curious to see if the filters will be a useful extension point for people who want to do things that would otherwise require local changes to the engine - non standard begin strings, for example.