[QFJ-704] New parameter "EnableResendRequest" to disable sending ResedRequest message Created: 14/Sep/12  Updated: 18/Sep/12  Resolved: 18/Sep/12

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.5.2
Fix Version/s: None

Type: New Feature Priority: Default
Reporter: Krzysztof Szalast Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None
Environment:

ALL

Issue Links:
Duplicate
duplicates QFJ-705 Redundant ResendRequest is sent after... Closed

 Description   

WSE in new system requires to not send ResendRequest Message. Gaps is filled by data from 789 tag. I propose to add new parameter:
EnableResendRequest=Y|N (default Y)
If "EnableResendRequest==N" then QuickFix/J don't send ResendRequests.

Affects methods:
quickfix.Session::nextSequenceReset(Message sequenceReset):
(...)
} else if (newSequence >= range[2]) {
state.setNextTargetMsgSeqNum(newSequence + 1);
final String beginString = sequenceReset.getHeader().getString(BeginString.FIELD);
if (this.enableResendRequest)

{ sendResendRequest(beginString, range[1] + 1, newSequence + 1, range[1]); }

}
(...)

and:

quickfix.Session::verify(Message msg, boolean checkTooHigh, boolean checkTooLow)
(...)
if (msgSeqNum < range[1] && range[2] > 0 && msgSeqNum >= range[2]) {
final String beginString = header.getString(BeginString.FIELD);
if (this.enableResendRequest)

{ sendResendRequest(beginString, range[1] + 1, msgSeqNum + 1, range[1]); }

}
(...)

and:

quickfix.Session::doTargetTooHigh(Message msg)
(...)
Last line:
if (this.enableResendRequest)

{ generateResendRequest(beginString, msgSeqNum); }

(...)

 Comments   
Comment by Andrzej Hajderek [ 17/Sep/12 ]

Having the same problem I proposed a smaller change (2 lines) that seems to work:

http://www.quickfixj.org/jira/browse/QFJ-705

Krzysztof,

If you tested it in your project and confirmed, it could help this case.

Comment by Christoph John [ 18/Sep/12 ]

Hi Krzysztof,

we will track the needed changes on QFJ-705 now. Hope that is OK for you.

Cheers,
Chris.

Generated at Sat Nov 23 11:32:40 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.