[QFJ-707] DefaultMessageFactory class docs should not advise users to make subclasses Created: 21/Sep/12 Updated: 09/Oct/12 Resolved: 09/Oct/12 |
|
Status: | Resolved |
Project: | QuickFIX/J |
Component/s: | Documentation |
Affects Version/s: | None |
Fix Version/s: | 1.5.3 |
Type: | Bug | Priority: | Default |
Reporter: | Grant Birchmeier | Assignee: | Grant Birchmeier |
Resolution: | Fixed | Votes: | 0 |
Labels: | None |
Description |
DefaultMessageFactory's docs say: "The default factory for creating FIX message instances. Create subclasses of this factory for generating custom messages using nonstandard message types." Looking at the source, this has to be wrong. There's no way a subclass of this can be useful, unless it entirely re-implements one or both of the create() methods, which are the only public methods anyway. Users should instead subclass MessageFactory, and pass that to the Socket/Session constructors. Suggested fix: Strike the second sentence from the above-quoted doc comment. |
Comments |
Comment by Grant Birchmeier [ 09/Oct/12 ] |
fixed in 1091 |
Comment by Christoph John [ 09/Oct/12 ] |
Changed assignee to Grant. |