[QFJ-821] Quickfix/J Server should validate SSL client certificates Created: 29/Dec/14 Updated: 13/Dec/16 Resolved: 26/Dec/15 |
|
Status: | Closed |
Project: | QuickFIX/J |
Component/s: | Engine |
Affects Version/s: | 1.5.2 |
Fix Version/s: | 1.6.3 |
Type: | Improvement | Priority: | Major |
Reporter: | harnit | Assignee: | Marcin L |
Resolution: | Fixed | Votes: | 1 |
Labels: | None | ||
Environment: |
O/S: Windows 8 |
Issue Links: |
|
Description |
In quickfix.mina.acceptor.AbstractSocketAcceptor we have sslFilter.setUseClientMode(false); What we found is this means that the Quickfix/J server never validates the client certificates. Can we please provide a configuration for this to enable needClientAuth? |
Comments |
Comment by harnit [ 29/Dec/14 ] |
Sorry can not edit the above comment. Just read the SSLFilter javadoc, setUseClientMode(false) seems correct Is there any work planned for this? |
Comment by Christoph John [ 30/Dec/14 ] |
I have edited the issue description. No, currently there are no plans to implement it. |
Comment by AE [ 06/Jul/15 ] |
Hi Christoph, I am wondering if there have been any changes on this? I think there is value in allowing a quickfixj acceptor to authenticate the client connecting to it. Thanks. |
Comment by Christoph John [ 07/Jul/15 ] |
Hi, I do not doubt that this would be sensible but at the moment I have very little time to work on this and there are still some pull requests open to be merged. Best thing would be if someone submitted a pull request for this. |
Comment by Marcin L [ 09/Dec/15 ] |
https://github.com/quickfix-j/quickfixj/pull/49 Contains fixes for |
Comment by Christoph John [ 19/Dec/15 ] |
Great, thanks. Just merged. |
Comment by Marcin [ 14/Jan/16 ] |
Hello, I can not build jar from current GITHUB source of quickfixj. here is the "SSL" error in the output of mvn package: Tests in error: Tests run: 1333, Failures: 2, Errors: 10, Skipped: 0 [INFO] ------------------------------------------------------------------------ |
Comment by Christoph John [ 14/Jan/16 ] |
From what I can see in the lines where it is failing is that it tries to create files in the temporary directory. Do you have write access there? But actually this belongs onto the quickfixj-users group: https://lists.sourceforge.net/lists/listinfo/quickfixj-users Thanks |