[QFJ-895] Reconnecting initiator does not work under some circumstances Created: 23/Jun/16 Updated: 13/Dec/16 Resolved: 11/Jul/16 |
|
| Status: | Closed |
| Project: | QuickFIX/J |
| Component/s: | None |
| Affects Version/s: | 1.6.2 |
| Fix Version/s: | 1.6.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Christoph John | Assignee: | Guido Medina |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||
| Description |
|
Youyu Shao provided some fixes on the mailing list. Original mail: On 23/06/16 02:35, Youyu Shao wrote: |
| Comments |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
I'm having this issue also with QFJ 1.7.x (current master), it seems that the initiator is never able to recover from this, I was still trying to figure out what this is happening: |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
The state issue with Apache Mina might has been fixed with latest, which isn't maybe what QFJ 1.6.3 is using? |
| Comment by Christoph John [ 23/Jun/16 ] |
|
Since QF/J 1.6.2 the MINA version 2.0.13 is used. You submitted a pull request for that. Do you have a link to the MINA issue which should fix this? On |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
You are right, it definitely looks like another problem, will you take care of that PR?, if you can't make it before 5:30PM London time I can download the patch files and send a PR. |
| Comment by Christoph John [ 23/Jun/16 ] |
|
Hi Guido, that would be great, thank you. I could not look at this earlier than next week or at the weekend. |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
Glad to do it, I'll send you a PR late tonight. |
| Comment by Christoph John [ 23/Jun/16 ] |
|
Thanks, really appreciated. |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
I was able to surgically modify the other 4 which I will commit on master, but IoSessionInitiator.java I couldn't after last SSL refactored. |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
Check commit: https://github.com/quickfix-j/quickfixj/pull/76/commits/d82566e3d5165fb3873dc253328a3a61d3054c66 |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
Concerning the class I couldn't patch, scratch that, I figured it out. |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
Simplified commit for easier code review: https://github.com/quickfix-j/quickfixj/pull/76/commits/a72d3ef5f7a9a99fd129d4430585d6591d1e2596 |
| Comment by Guido Medina [ 23/Jun/16 ] |
|
PRs submitted for the following branches: |
| Comment by Guido Medina [ 24/Jun/16 ] |
|
The patch broke a test by moving getNextSocketAddress() to inside a try...catch, for this case this exception needs to be thrown: https://github.com/quickfix-j/quickfixj/pull/78 |