[QFJ-937] MaxScheduledWriteRequests is ineffective Created: 13/Oct/17  Updated: 19/Mar/18  Resolved: 19/Mar/18

Status: Resolved
Project: QuickFIX/J
Component/s: None
Affects Version/s: 1.6.4
Fix Version/s: 2.0.1

Type: Bug Priority: Major
Reporter: David Gibbs Assignee: David Gibbs
Resolution: Fixed Votes: 0
Labels: None

Attachments: Text File 0001-change-implementation-to-max-scheduled-write-bytes.patch    
Issue Links:
Relates
relates to QFJ-833 Add Slow Consumer Protection Closed

 Description   

Due to a defect in Apache Mina 2.0.16 MaxScheduledWriteRequests is inefective.
MaxScheduledWriteBytes would work.
A bug fix is in progress see : https://issues.apache.org/jira/browse/DIRMINA-1057
For a demonstration of the defect see https://github.com/david-gibbs-ig/mina-test-case
See also MAILING LIST.

 Comments   
Comment by David Gibbs [ 13/Oct/17 ]

Attached is a patch for IoSessionResponderTest that just extends coverage a little. It does not demonstrate this defect.
See https://github.com/david-gibbs-ig/mina-test-case for an integration test that demonstrates the mina issue with quickfixj codec.
: quickfix.mina.message.FIXProtocolCodecFactory

Comment by David Gibbs [ 16/Oct/17 ]

The bug fix for this will be in mina 2.0.17.

Comment by Christoph John [ 23/Oct/17 ]

Hi David Gibbs,

Attached is a patch for IoSessionResponderTest that just extends coverage a little. It does not demonstrate this defect.

hmm, the test testMaxScheduledWriteBytesExceeded is failing for me.

???

Comment by David Gibbs [ 23/Oct/17 ]

My mistake, you can see I was working with MaxScheduledWriteBytes rather than MaxScheduledWriteMessages (as in the master branch).
Leave that with me, I'll line it up with master.
Apache Mina 2.0.17 is not yet released.

Comment by Christoph John [ 26/Oct/17 ]

I'm still unsure if we should wait for MINA 2.0.17 to be released and rather put this issue into QFJ 2.0.1? Even if MINA 2.0.17 was released in October there is not much time left to test QFJ with the new MINA version since I'd like to have QFJ 2.0.0 released in a few weeks the latest.
What do you think?

Edit: there are also still some issues open to be fixed for MINA 2.0.17.

Cheers,
Chris.

Comment by Christoph John [ 06/Nov/17 ]

OK, timeout. Putting this into 2.0.1 since MINA is still not released.

Comment by Christoph John [ 13/Mar/18 ]

Can be closed once https://github.com/quickfix-j/quickfixj/pull/177 has been merged.

Comment by David Gibbs [ 15/Mar/18 ]

Excellent !

Generated at Sat Nov 23 07:32:47 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.