[QFJ-953] withQueueWatermarks always throws exception Created: 11/Sep/18  Updated: 11/Jan/19  Resolved: 20/Sep/18

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 2.1.0
Fix Version/s: 2.1.1

Type: Bug Priority: Default
Reporter: Mariusz B Assignee: Mariusz B
Resolution: Fixed Votes: 0
Labels: None


 Description   

Following code snippet:
{{
int lower = 10;
int upper = 20;
return SocketAcceptor.newBuilder()
.withQueueWatermarks(lower, upper)
.build();
}}

always ends up with exception:

{{
11:15:17 Caused by: quickfix.ConfigError: invalid queue watermarks, required: 0 <= lower watermark < upper watermark
11:15:17 at quickfix.AbstractSessionConnectorBuilder.withQueueWatermarks(AbstractSessionConnectorBuilder.java:58)
}}}

Method withQueueWatermarks should verify parameters instead of class fields.

 Comments   
Comment by Christoph John [ 11/Sep/18 ]

Hi Mariusz B,

thanks for the report. Are you able to create a pull request with the fix?
https://github.com/quickfix-j/quickfixj

Thanks,
Chris.

Generated at Sat Nov 23 00:09:03 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.