[QFJ-965] Regression when using non-default charset Created: 22/Nov/18  Updated: 11/Jan/19  Resolved: 24/Nov/18

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 2.1.0
Fix Version/s: 2.1.1

Type: Bug Priority: Default
Reporter: amichair Assignee: amichair
Resolution: Fixed Votes: 0
Labels: None


 Description   

The optimizations in commit 6229d0722d8c6f6e7b2b251772a92caf2f4bdc25 cause a regression where using fields with a non-default charset such as UTF-8 causes message corruption (even if the charset is properly set via CharsetSupport.setCharset()).

Further, the test that caught this regression (MessageTest.testMessageWithEncodedField via its helper method) was modified in the same commit to work around the test failure, so that the test passes but the bug still occurs in real applications..

I will submit a PR shortly with a fix.

 Comments   
Comment by Christoph John [ 22/Nov/18 ]

Hi amichair

good catch. I did not spot this when working on the original commit :-/

Do you think that this is the same issue as QFJ-956?

Thanks
Chris.

Comment by amichair [ 22/Nov/18 ]

I'm not sure I understand what the issue in QFJ-956 is exactly, it sounds like it might be a general issue of how to configure the charset the same as the counter-party. I don't see an immediate connection to the code that was fixed here, but maybe I misunderstood what the reporter there meant.

Comment by amichair [ 23/Nov/18 ]

For reference, here is the PR.

Generated at Sat Nov 23 00:28:14 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.