Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-192

Format generated message source code to adhere to Java indentation standards

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Default
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: Build
    • Labels:
      None

      Description

      Currently, the XSLT generating the quickfix.fix4x messages doesn't distinguish between inner classes and regular "outer" class when generating the getter/setter methods.

      as a result, they are all indented the same way, making it harder to distinguish where a particular method lives.
      See the thread for more info: http://www.nabble.com/QuoteRequest.set%28QuoteRequestType%29-and-various-other-set-methods-missing--tf3876614.html

      Since the same XSLT template is used to generate getter/setter methods for outer and nested classes, it's not that easy to fix this in XSLT itself.

      May be easier to fix it in the build directly, via a post-generation ANT task (something like Jalopy: http://jalopy.sourceforge.net/existing/plugin-ant.html).

      Let me know if you know of any other code-formatting tools we can use instead, or if there may be a better way to achieve this, and i'll implement this in the build file.

        Attachments

          Activity

            People

            • Assignee:
              toli Toli Kuznets
              Reporter:
              toli Toli Kuznets
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: