Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-321

PersistMessages config parameter default value is wrong in the QuickFIX/J User Manual

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Default
    • Resolution: Not a bug
    • Affects Version/s: 1.3.1
    • Fix Version/s: None
    • Component/s: Documentation, Engine
    • Labels:
      None

      Description

      The QuickFIX/J User Manual says that the default value of the PersistMessages parameter is "N" (false). But in the DefaultSessionFactory its default value is true (line 150):

                  boolean persistMessages = getSetting(settings, sessionID,
                          Session.SETTING_PERSIST_MESSAGES, true);
      

      If this parameter is set to true, then there is a memory leak in the FileStore class. The size of HashMap messageIndex is growing all the time. The reset() method does not clear this map.

        Attachments

          Issue Links

            Activity

            Hide
            admin Steve Bate added a comment -

            Are you using the documentation that is shipped with QFJ or the online documentation? The online documentation is sometimes a bit out of date. If it's a problem with the online documentation I'll be sure to update it when I release 1.3.2 (any day now). The PersistMessages docs should be correct in the 1.3.1 distribution. The value was changed in SVN revision 748 and the 1.3.1 release tag is revision 786.

            The messageIndex is cleared by reset.

            reset() -> initialize() --> initializeCache() --> initializeMessageIndex() --> messageIndex.clear() ...

            Show
            admin Steve Bate added a comment - Are you using the documentation that is shipped with QFJ or the online documentation? The online documentation is sometimes a bit out of date. If it's a problem with the online documentation I'll be sure to update it when I release 1.3.2 (any day now). The PersistMessages docs should be correct in the 1.3.1 distribution. The value was changed in SVN revision 748 and the 1.3.1 release tag is revision 786. The messageIndex is cleared by reset. reset() -> initialize() --> initializeCache() --> initializeMessageIndex() --> messageIndex.clear() ...

              People

              • Assignee:
                Unassigned
                Reporter:
                baxter Baxter Solutions
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: