Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-402

Provide useful exception description for IncorrectTagValue, NoTagValue and other FIX specific exceptions

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Default
    • Resolution: Fixed
    • Affects Version/s: 1.3.1, 1.3.2, 1.3.3
    • Fix Version/s: 1.4.0
    • Component/s: Engine
    • Labels:
      None

      Description

      The FieldNotFound exception contains a useful exception description, which can be fetched with e.getMessage():

          public FieldNotFound(int field) {
              super("Field ["+field+"] was not found in message.");
              this.field = field;
          }
      

      but other FIX exceptions as IncorrectTagValue or NoTagValue etc. lacks these description text.
      This is not consistent with the second constructor using a String description text.

      Provide useful description text for IncorrectTagValue, NoTagValue and possibly other FIX exceptions.

        Attachments

          Activity

          Hide
          jthoennes Jörg Thönnes added a comment -

          Laurent, for the moment I would like to resolve this issue as fixed.

          There are a couple of other exception migrated from the C++ JNI API, which need improvements:

          • missing exception descriptions
          • constructors lacking description messages

          I removed two constructors from the NoTagValue exception, but now I am unsure whether this breaks the C++ JNI API compatibility. Please re-add the constructors if you think so.

          Please include this in the 1.4.0 release hopefully coming soon.

          Show
          jthoennes Jörg Thönnes added a comment - Laurent, for the moment I would like to resolve this issue as fixed. There are a couple of other exception migrated from the C++ JNI API, which need improvements: missing exception descriptions constructors lacking description messages I removed two constructors from the NoTagValue exception, but now I am unsure whether this breaks the C++ JNI API compatibility. Please re-add the constructors if you think so. Please include this in the 1.4.0 release hopefully coming soon.

            People

            • Assignee:
              ldanesi Laurent Danesi
              Reporter:
              jthoennes Jörg Thönnes
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: