Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-601

FIX protocol version 4.4 filed InstrAttribType (871) should include the types described in "Description" section.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Default
    • Resolution: Fixed
    • Affects Version/s: 1.4.0, 1.5.0
    • Fix Version/s: 1.5.1
    • Component/s: Engine
    • Labels:

      Description

      Documentation Links
      http://www.onixs.biz/tools/fixdictionary/4.4/tagNum_871.html
      http://fixprotocol.org/FIXimate3.0/en/FIX.4.4/tag871.html

      The Types which I didn't find in InstrAttribType (871) field in FIX44.xml file are:
      <value enum="10" description="ORIGINAL_ISSUE_DISCOUNT"/>
      <value enum="11" description="CALLABLE_PUTTABLE"/>
      <value enum="12" description="ESCROWED_TO_MATURITY"/>
      <value enum="13" description="ESCROWED_TO_REDEMPTION_DATE"/>
      <value enum="14" description="PRE_REFUNDED"/>
      <value enum="15" description="IN_DEFAULT"/>
      <value enum="16" description="UNRATED"/>
      <value enum="17" description="TAXABLE"/>
      <value enum="18" description="INDEXED"/>
      <value enum="19" description="SUBJECT_TO_ALTERNATIVE_MINIMUM_TAX"/>
      <value enum="20" description="ORIGINAL_ISSUE_DISCOUNT_PRICE_SUPPLY_PRICE_IN_THE_INSTRATTRIBVALUE"/>
      <value enum="21" description="CALLABLE_BELOW_MATURITY_VALUE"/>
      <value enum="22" description="CALLABLE_WITHOUT_NOTICE_BY_MAIL_TO_HOLDER_UNLESS_REGISTERED"/>
      <value enum="99" description="TEXT_SUPPLY_THE_TEXT_OF_THE_ATTRIBUTE_OR_DISCLAIMER_IN_THE_INSTRATTRIBVALUE"/>

      Missing data affect error-checking in the InstrAttribType (871) field further in the code.

        Attachments

          Activity

          Hide
          ed1978 Eric Deshayes added a comment -

          Committed in rev#1040

          Show
          ed1978 Eric Deshayes added a comment - Committed in rev#1040
          Hide
          jthoennes Jörg Thönnes added a comment -

          In reply to comment #1:
          > Committed in rev#1040

          Ha! You were faster than me. Just picked this up.

          How about replacing

                <value enum="20" description="ORIGINAL_ISSUE_DISCOUNT_PRICE_SUPPLY_PRICE_IN_THE_INSTRATTRIBVALUE"/>
                <value enum="99" description="TEXT_SUPPLY_THE_TEXT_OF_THE_ATTRIBUTE_OR_DISCLAIMER_IN_THE_INSTRATTRIBVALUE"/>
          

          by

                <value enum="20" description="ORIGINAL_ISSUE_DISCOUNT_PRICE"/>
                <value enum="99" description="TEXT"/>
          

          as specified in the FIXimate? To me this very long text makes no sense. I think it was
          generated by some automatic conversion tool from the FIX 5.0 spec:

          20 = Original issue discount price. Supply price in the InstrAttribValue (872) field
          21 = Callable below maturity value
          22 = Callable without notice by mail to holder unless registered
          99 = Text. Supply the text of the attribute or disclaimer in the InstrAttribValue (872) field.

          In addition, I would also adapt FIX 5.0 in due course.

          Show
          jthoennes Jörg Thönnes added a comment - In reply to comment #1: > Committed in rev#1040 Ha! You were faster than me. Just picked this up. How about replacing <value enum = "20" description= "ORIGINAL_ISSUE_DISCOUNT_PRICE_SUPPLY_PRICE_IN_THE_INSTRATTRIBVALUE" /> <value enum = "99" description= "TEXT_SUPPLY_THE_TEXT_OF_THE_ATTRIBUTE_OR_DISCLAIMER_IN_THE_INSTRATTRIBVALUE" /> by <value enum = "20" description= "ORIGINAL_ISSUE_DISCOUNT_PRICE" /> <value enum = "99" description= "TEXT" /> as specified in the FIXimate? To me this very long text makes no sense. I think it was generated by some automatic conversion tool from the FIX 5.0 spec: 20 = Original issue discount price. Supply price in the InstrAttribValue (872) field 21 = Callable below maturity value 22 = Callable without notice by mail to holder unless registered 99 = Text. Supply the text of the attribute or disclaimer in the InstrAttribValue (872) field. In addition, I would also adapt FIX 5.0 in due course.
          Hide
          jthoennes Jörg Thönnes added a comment -

          Renamed enum constants for FIX 4.4 and FIX 5.0 field 871/InstrAttribType. The trailing part of the name
          for value 20 and 99 was append by mistake. In the FIXimate, this part is just an extra comment and not
          part of the name.

          Show
          jthoennes Jörg Thönnes added a comment - Renamed enum constants for FIX 4.4 and FIX 5.0 field 871/InstrAttribType. The trailing part of the name for value 20 and 99 was append by mistake. In the FIXimate, this part is just an extra comment and not part of the name.

            People

            • Assignee:
              Unassigned
              Reporter:
              andrey-z Andrey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: