Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-813

SessionConnector:waitForLogout()'s InterruptedException handling.

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Default
    • Resolution: Unresolved
    • Affects Version/s: 1.5.3
    • Fix Version/s: 2.1-BETA
    • Component/s: Engine
    • Labels:
      None

      Description

      When the executing thread is interrupted the waitForLogout() method catches it and prints and error to log.

      I would like to suggest that the exception is either thrown or at least re-asserted so that higher level application code can handle it. Also I would like to suggest that nothing is printed to the log file.

      This would:

      • Let higher level application code realize that an interruption has occurred.
      • Stop the engine as requested (if it's thrown).
      • Let higher level application code handler the interruption properly.
      • Let higher level application code decide what to print in the log file.

      Currently after the interruption is requested there is no way to know whether the engine actually stopped.
      Also the log file is polluted (in my opinion) with a stack dump whereas this is not an actual error condition.

      I supposed a similar behavior would be desirable in all other equivalent places in the code.

      I would be interested to hearing your opinion about it.

      Many thanks.
      Francesco Lo Conte

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              francesco.loconte Francesco Lo Conte
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: