Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-304

EST Timezone SessionScheduleTest.testSettingsWithoutStartEndDayWithTimeZoneInTime()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Default
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.3.2
    • Component/s: Build
    • Labels:
      None
    • Environment:
      OS X 10.5.2
      Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_13-b05-237)
      Java HotSpot(TM) Client VM (build 1.5.0_13-119, mixed mode, sharing)

      Description

      SessionScheduleTest.testSettingsWithoutStartEndDayWithTimeZoneInTime() uses the timezone "EST" when it sets the Session.SETTING_START_TIME and when it sets the tz for the "current time" in the tests. It uses "US/Central" for the Session.SETTING_END_TIME.

      The tests that follow assume that "US/Central" is 1 hour behind "EST". This is not always true. "US/Central" accounts for Daylight Savings and "EST" does not. So, during DST, the difference between these zones is 0 hours.

      This causes the following test to fail (line 398 in version 1.3.1), because it relies on the 1 hour timezone difference:
      doIsSessionTimeTest(schedule, true, 2003, 5, 5, 15, 59, 0, tz);

      I suggest using "US/Eastern" instead of "EST" in this test so that the test passes year round.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dvain Dustin Vain
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: