Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-543

"connector" parameter in interface AcceptorSessionProvider.getSession() is undocumented and unclear

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.5.0
    • Fix Version/s: None
    • Component/s: Engine
    • Labels:
      None

      Description

      See paste below from AcceptorSessionProvider. The parameter connector is absent from the javadoc, and it's not clear what it's for. As it's an interface, the parameter's purpose should be documented.

      From the two instantiations of this interface (DynamicAcceptorSessionProvider and AbstractSocketAcceptor::StaticAcceptorSessionProvider), it appears this parameter is only used for dynamic sessions and is otherwise ignored.

      /**

      • Return a session for this sessionID. The session might be
      • created dynamically.
      • @param sessionID
      • @return the associated session or null if no session can be
      • associated with the given ID.
        */
        Session getSession(SessionID sessionID, SessionConnector connector);

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              grantb Grant Birchmeier
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: