Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-707

DefaultMessageFactory class docs should not advise users to make subclasses

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.3
    • Component/s: Documentation
    • Labels:
      None

      Description

      DefaultMessageFactory's docs say:

      "The default factory for creating FIX message instances. Create subclasses of this factory for generating custom messages using nonstandard message types."

      Looking at the source, this has to be wrong. There's no way a subclass of this can be useful, unless it entirely re-implements one or both of the create() methods, which are the only public methods anyway.

      Users should instead subclass MessageFactory, and pass that to the Socket/Session constructors.

      Suggested fix: Strike the second sentence from the above-quoted doc comment.

        Attachments

          Activity

            People

            • Assignee:
              grantb Grant Birchmeier
              Reporter:
              grantb Grant Birchmeier
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: